Don't use StringData::data() to create String or std:strings
commit5f1fd063145d803f042fb61192626e92c978233a
authorEdwin Smith <smith@fb.com>
Wed, 30 Sep 2015 14:29:48 +0000 (30 07:29 -0700)
committerhhvm-bot <hhvm-bot@fb.com>
Wed, 30 Sep 2015 15:01:32 +0000 (30 08:01 -0700)
tree168d1f9d083cc26c5ec346370130b1cb2ab2729c
parentc4e0e8b4d82ae9a06b45a80ba9fc68584aa5d604
Don't use StringData::data() to create String or std:strings

Summary: it's silly, and it can give you a different string if there are
nul (\0) characters.

Reviewed By: @ricklavoie, @alexmalyshev

Differential Revision: D2490184
hphp/runtime/debugger/break_point.cpp
hphp/runtime/debugger/debugger_hook_handler.cpp