| commit | 5ea6824dde6a6a09fadd75e319b80ac6984b0cb9 | |
| author | Kasper Kopec <kasper@fb.com> | |
| Tue, 12 Dec 2017 02:59:21 +0000 (11 18:59 -0800) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Tue, 12 Dec 2017 03:11:41 +0000 (11 19:11 -0800) | ||
| tree | 9bb72a60f4ed387e8f46793aef17bad02064db7a | treesnapshot (tar.gz zip) |
| parent | 12ffb1d831d482f5e4f58aeb976acfd159fea71f | commitdiff |
Respect keep_errors flag in Parser_hack for lexer errors
Summary:
Random crash I encountered while testing unrelated changes.
Parser_hack has it's own error system, which then feeds (or not, depending on ~keep_errors) flag into global Errors module. But Parse_hack also calls into lexer, which has direct calls to Errors:
diffusion/FBS/browse/master/fbcode/hphp/hack/src/parser/lexer_hack.mll$498,513,522,530,540,548,573,617
effectively bypassing keep_errors.
Reviewed By: jamesjwu
Differential Revision: D6393239
fbshipit-source-id: 0fa86300763f836ffcd0700a22a78e415cce9a20
Summary:
Random crash I encountered while testing unrelated changes.
Parser_hack has it's own error system, which then feeds (or not, depending on ~keep_errors) flag into global Errors module. But Parse_hack also calls into lexer, which has direct calls to Errors:
diffusion/FBS/browse/master/fbcode/hphp/hack/src/parser/lexer_hack.mll$498,513,522,530,540,548,573,617
effectively bypassing keep_errors.
Reviewed By: jamesjwu
Differential Revision: D6393239
fbshipit-source-id: 0fa86300763f836ffcd0700a22a78e415cce9a20
| hphp/hack/src/parser/parser_hack.ml | diffblobblamehistory | |
| hphp/hack/test/outline/lexer_error.php | [new file with mode: 0644] | blob |