| commit | 5d674bb81b0fa11eb545fdec71604c002e4cbc7e | |
| author | Jordan DeLong <jdelong@fb.com> | |
| Sun, 22 Dec 2013 21:55:06 +0000 (22 13:55 -0800) | ||
| committer | Sara Golemon <sgolemon@fb.com> | |
| Tue, 24 Dec 2013 22:11:02 +0000 (24 14:11 -0800) | ||
| tree | 10a2637a53d0ec258e2117e79aa083d87a6158cf | treesnapshot (tar.gz zip) |
| parent | c0995e0acd689382b6a00716d481f9bfbc2f2bc7 | commitdiff |
Fix an issue with empty async function closures---finishStatement off by one
Also remove a "useless non-terminal" warning (an old rule was
accidentally left in). This only affected empty async function
closures, since the onClosure itself wasn't off by one, and all
finishStatement does is replace empty statement lists.
Reviewed By: @edwinsmith
Differential Revision: D1109810
Also remove a "useless non-terminal" warning (an old rule was
accidentally left in). This only affected empty async function
closures, since the onClosure itself wasn't off by one, and all
finishStatement does is replace empty statement lists.
Reviewed By: @edwinsmith
Differential Revision: D1109810
| hphp/compiler/parser/hphp.tab.cpp | diffblobblamehistory | |
| hphp/parser/hphp.y | diffblobblamehistory | |
| hphp/test/slow/async/empty_closure.php | [new file with mode: 0644] | blob |
| hphp/test/slow/async/empty_closure.php.expect | [new file with mode: 0644] | blob |