| commit | 5d60c6389d28664d47db16ce551f9798e3fd5bcb | |
| author | aravind <aravind@fb.com> | |
| Sat, 14 Jun 2014 05:24:12 +0000 (13 22:24 -0700) | ||
| committer | facebook-github-bot <githubbot@fb.com> | |
| Tue, 24 Jun 2014 21:45:07 +0000 (24 14:45 -0700) | ||
| tree | 6cabf72c7166f62528f3b88bfed1c2360f026db7 | treesnapshot (tar.gz zip) |
| parent | ee0bb6941ce91ec3ccc5fa3639d5986c9853c3b4 | commitdiff |
Fix hhhbc for SetElem with non-array bases.
Summary: If the base is not an array or an object implementing ArrayAccess,
SetM pushes a null. This was not being handled correctly hhbbc, and
we were pushing the rhs on stack in these cases.
Reviewed By: @jdelong
Differential Revision: D1383973
Summary: If the base is not an array or an object implementing ArrayAccess,
SetM pushes a null. This was not being handled correctly hhbbc, and
we were pushing the rhs on stack in these cases.
Reviewed By: @jdelong
Differential Revision: D1383973
| hphp/hhbbc/interp-minstr.cpp | diffblobblamehistory |