Don't check safepoint flags in check_request_surprise_unlikely()
commit5d276f4cdc00c279bb647e01f520b6f9743622e0
authorMax Wang <mwang@fb.com>
Sat, 20 Aug 2016 06:19:43 +0000 (19 23:19 -0700)
committerHhvm Bot <hhvm-bot-bot@fb.com>
Sat, 20 Aug 2016 06:36:08 +0000 (19 23:36 -0700)
treed1309ad81e47f4f02acffaa50e6bc87cf5c99dea
parent3450f9eca32525621e72a14742125874354d6cad
Don't check safepoint flags in check_request_surprise_unlikely()

Summary:
check_request_surprise_unlikely() exists specifically to check for
resource exceeded conditions when running unbounded native operations
like array unserialization or JSON decoding.  These places, at least
presently, are not MemoryManager safepoints, so exclude safepoint-
only flags from the check.

Also rename the function, to make it clearer what its purpose is.

Reviewed By: markw65

Differential Revision: D3744616

fbshipit-source-id: 9bc7455fe0d44dc9dfc2e0bb55205f2a792200de
hphp/runtime/base/array-init.cpp
hphp/runtime/base/array-init.h
hphp/runtime/base/array-util.cpp
hphp/runtime/base/surprise-flags.h
hphp/runtime/base/thread-info.cpp
hphp/runtime/base/thread-info.h
hphp/runtime/base/variable-unserializer.cpp
hphp/runtime/ext/json/JSON_parser.cpp
hphp/tools/oss_hot_section_ordering