Add flag to fatal when meth_caller used with non-literals
commit5b10d603fe31655db27a7905cbd0822c32c8f002
authorPaul Bissonnette <paulbiss@fb.com>
Thu, 4 Feb 2021 21:59:56 +0000 (4 13:59 -0800)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Thu, 4 Feb 2021 22:02:11 +0000 (4 14:02 -0800)
treefb78a72f4fb2a771a340a60b55fddee1b713b05c
parent3978f9678d10a216dab8760e2f6c17200e04015a
Add flag to fatal when meth_caller used with non-literals

Summary: Add stricter checking for non-literal arguments to meth_caller (gated by an option) to aid with the rollout of meth_caller.

Reviewed By: oulgen

Differential Revision: D26180697

fbshipit-source-id: 0bfc4bdb0d0bec41ed2c41474a85cfc4e61c7cfd
15 files changed:
hphp/hack/src/hhbc/closure_convert.rs
hphp/hack/src/hhbc/options.rs
hphp/runtime/base/runtime-option.h
hphp/test/slow/meth-caller-bad-cls.php [new file with mode: 0644]
hphp/test/slow/meth-caller-bad-cls.php.expectf [new file with mode: 0644]
hphp/test/slow/meth-caller-bad-cls.php.hphp_opts [new file with mode: 0644]
hphp/test/slow/meth-caller-bad-cls.php.opts [new file with mode: 0644]
hphp/test/slow/meth-caller-bad-meth-2.php [new file with mode: 0644]
hphp/test/slow/meth-caller-bad-meth-2.php.expectf [new file with mode: 0644]
hphp/test/slow/meth-caller-bad-meth-2.php.hphp_opts [new file with mode: 0644]
hphp/test/slow/meth-caller-bad-meth-2.php.opts [new file with mode: 0644]
hphp/test/slow/meth-caller-bad-meth.php [new file with mode: 0644]
hphp/test/slow/meth-caller-bad-meth.php.expectf [new file with mode: 0644]
hphp/test/slow/meth-caller-bad-meth.php.hphp_opts [new file with mode: 0644]
hphp/test/slow/meth-caller-bad-meth.php.opts [new file with mode: 0644]