| commit | 5ad91a491e7464890541b9560765bed613802d20 | |
| author | Catherine Gasnier <catg@fb.com> | |
| Fri, 13 Sep 2019 10:00:37 +0000 (13 03:00 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Fri, 13 Sep 2019 10:03:00 +0000 (13 03:03 -0700) | ||
| tree | 0f4bcc076b5f17169700fd1af3e699f666db3a23 | treesnapshot (tar.gz zip) |
| parent | 0ad75ecaaaa31808ddc60c06e89a3038f49d793e | commitdiff |
simplify Typing_union
Summary:
There is some redundancy in the treatment of null, options, unions and intersections in Typing_union, which appear both in `union_` and `union_lists`. This diff makes `union` call directly into `union_list` so as to get rid of the cases in `union_` dealing with null, options, unions, intersections.
We however then need to simplify away nonnull when the result is nullable, which is done in `make_union`. See doc comments for more details.
We also get rid of exception `Not_equiv` to replace it with returning an option.
Reviewed By: andrewjkennedy
Differential Revision: D17208027
fbshipit-source-id: aeda3c753d7e74bc67575b75105d7b31a6319453
Summary:
There is some redundancy in the treatment of null, options, unions and intersections in Typing_union, which appear both in `union_` and `union_lists`. This diff makes `union` call directly into `union_list` so as to get rid of the cases in `union_` dealing with null, options, unions, intersections.
We however then need to simplify away nonnull when the result is nullable, which is done in `make_union`. See doc comments for more details.
We also get rid of exception `Not_equiv` to replace it with returning an option.
Reviewed By: andrewjkennedy
Differential Revision: D17208027
fbshipit-source-id: aeda3c753d7e74bc67575b75105d7b31a6319453
100 files changed: