| commit | 5ac1f2455e743b2a2d04e348c92f682df3ac4684 | |
| author | Martyna Siejba <tysia2512@fb.com> | |
| Wed, 11 Sep 2019 20:55:14 +0000 (11 13:55 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Wed, 11 Sep 2019 21:01:09 +0000 (11 14:01 -0700) | ||
| tree | 3deaa2070cd5d26e94e81c861b650e02623504cb | treesnapshot (tar.gz zip) |
| parent | ab3684fee6fd871917060114798df5aebde79270 | commitdiff |
Don't require xbox_process_call_message and functions called with it to use dynamic pointers
Summary:
The use of `fb_call_user_func` resulted in `xbox_process_call_message` and functions passed as callables being logged as dynamic calls done without function pointers. We don't want to require such calls to use dynamic pointers, only to be marked `__DynamicallyCallable` (not `xbox_process_call_message` though). This diff:
- disables logging of calls done as rpc, http or cli server requests;
- disables logging of calls done specifically via `xbox_process_call_message`.
I try to achieve it by adding additional bool parameter in `callerDynamicCallChecks` which is propagated up
True passed as `allowDynCallNoPointer` to `hphp_invoke` from rpc-request-handler.cpp silences logging for `xbox_process_call_message`.
True passed as `allowDynCallNoPointer` to `vm_call_user_func` from `xbox_process_call_message` implementation silences jit and non-jit logs coming from functions passed as argument to `xbox_process_call_message`.
Reviewed By: ricklavoie
Differential Revision: D17198555
fbshipit-source-id: 4e43e1da9fc4600dad517b53b104637c9ab9a15b
Summary:
The use of `fb_call_user_func` resulted in `xbox_process_call_message` and functions passed as callables being logged as dynamic calls done without function pointers. We don't want to require such calls to use dynamic pointers, only to be marked `__DynamicallyCallable` (not `xbox_process_call_message` though). This diff:
- disables logging of calls done as rpc, http or cli server requests;
- disables logging of calls done specifically via `xbox_process_call_message`.
I try to achieve it by adding additional bool parameter in `callerDynamicCallChecks` which is propagated up
True passed as `allowDynCallNoPointer` to `hphp_invoke` from rpc-request-handler.cpp silences logging for `xbox_process_call_message`.
True passed as `allowDynCallNoPointer` to `vm_call_user_func` from `xbox_process_call_message` implementation silences jit and non-jit logs coming from functions passed as argument to `xbox_process_call_message`.
Reviewed By: ricklavoie
Differential Revision: D17198555
fbshipit-source-id: 4e43e1da9fc4600dad517b53b104637c9ab9a15b
23 files changed: