| commit | 5a529f2fbc44bbc1d78d77ad9bea5620415e203b | |
| author | Nick Benton <pnb@fb.com> | |
| Sat, 27 Jan 2018 13:43:12 +0000 (27 05:43 -0800) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Sat, 27 Jan 2018 13:45:55 +0000 (27 05:45 -0800) | ||
| tree | 32c66ea0d38f01a6137d75509e225ab8651bac3f | treesnapshot (tar.gz zip) |
| parent | 2d542798db9b6e95c13db25b5cee70efa5e90d5c | commitdiff |
allow ? as first character of ID in lexer
Summary:
hhas files can apparently have question marks at the start of
arguments, as in AssertRATL $argc ?Int. We extend the lexer to allow ?
as the first character of an ID token. This is far too generous, as ID
is used in various other places where ? certainly shouldn't be
allowed, but I think it's OK for parsing well-formed inputs.
Reviewed By: vladima, gregory-nisbet
Differential Revision: D6821726
fbshipit-source-id: 13a3d523c2e5b80ba19bec4abb9287dee8e0529b
Summary:
hhas files can apparently have question marks at the start of
arguments, as in AssertRATL $argc ?Int. We extend the lexer to allow ?
as the first character of an ID token. This is far too generous, as ID
is used in various other places where ? certainly shouldn't be
allowed, but I think it's OK for parsing well-formed inputs.
Reviewed By: vladima, gregory-nisbet
Differential Revision: D6821726
fbshipit-source-id: 13a3d523c2e5b80ba19bec4abb9287dee8e0529b
| hphp/hack/src/hhbc/hhas_lexer.mll | diffblobblamehistory |