Split is_array notices away from is_{vec,dict} notices
commit5a2829328bc17b253d8d1b9b246b8367a105a484
authorJoseph Griego <jgriego@fb.com>
Fri, 27 Jul 2018 14:22:57 +0000 (27 07:22 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Fri, 27 Jul 2018 14:27:44 +0000 (27 07:27 -0700)
treee0ad5183fd615423db22680e1a226ee94b03f51b
parent7e3a2ecc78d6d57c4a1bd80a50a4bac1eabdc007
Split is_array notices away from is_{vec,dict} notices

Summary:
HF asked if we can split these notices to be behind two different
runtime flags, to reduce noise from callsites that aren't actionable
pre-migration. I added a new flag `[HAC]IsVecDictNotices` to control the
notices for `is_vec` and `is_dict`

Reviewed By: mxw

Differential Revision: D8901136

fbshipit-source-id: de884eac2d0845f6d4606c7d125eac4e2520ec50
15 files changed:
hphp/hhbbc/type-system.cpp
hphp/runtime/base/runtime-option.h
hphp/runtime/base/type-structure-helpers.cpp
hphp/runtime/ext/std/ext_std_variable.cpp
hphp/runtime/vm/bytecode.cpp
hphp/runtime/vm/jit/irgen-types.cpp
hphp/runtime/vm/repo-global-data.h
hphp/test/slow/hack_arr_compat/is_array.php.hphp_opts
hphp/test/slow/hack_arr_compat/is_array.php.opts
hphp/test/slow/hack_arr_compat/is_array_2.php [new file with mode: 0644]
hphp/test/slow/hack_arr_compat/is_array_2.php.expectf [new file with mode: 0644]
hphp/test/slow/hack_arr_compat/is_array_2.php.hphp_opts [new file with mode: 0644]
hphp/test/slow/hack_arr_compat/is_array_2.php.opts [copied from hphp/test/slow/hack_arr_compat/is_array.php.opts with 100% similarity]
hphp/test/slow/is_expression/is-expression-hack-array-compat.php.hphp_opts
hphp/test/slow/is_expression/is-expression-hack-array-compat.php.opts