| commit | 59dd8be6762613990a5df90e31b8075f0b81e2bb | |
| author | Jeff Hemphill <jhemphill@fb.com> | |
| Fri, 11 Jun 2021 01:11:08 +0000 (10 18:11 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Fri, 11 Jun 2021 01:14:38 +0000 (10 18:14 -0700) | ||
| tree | fec5d44b3fd97a0d2a7dac767fa6367e24fb956d | treesnapshot (tar.gz zip) |
| parent | 95ad357f4ba5f95695f804b28a777ec628081d1a | commitdiff |
Refactor WatchmanAutoloadMap into FactsStoreImpl
Summary:
Facts has historically depended on Watchman to track file changes. Open-source users may not have access to Watchman, and we do need everyone in open-source to get onto native autoloading so we can remove `require_once` from the Hack language.
This diff renames `WatchmanAutoloadMap` to `FactsStoreImpl`, moving Watchman details out of the header. Really, this moves pretty much everything out of the header.
The next diff factors Watchman functionality into one implementation of a `Watcher` interface, which may use Watchman or may not.
Reviewed By: fredemmott
Differential Revision: D29018377
fbshipit-source-id: b4b1369d0f5875d3349df1930c876208f88f01e4
Summary:
Facts has historically depended on Watchman to track file changes. Open-source users may not have access to Watchman, and we do need everyone in open-source to get onto native autoloading so we can remove `require_once` from the Hack language.
This diff renames `WatchmanAutoloadMap` to `FactsStoreImpl`, moving Watchman details out of the header. Really, this moves pretty much everything out of the header.
The next diff factors Watchman functionality into one implementation of a `Watcher` interface, which may use Watchman or may not.
Reviewed By: fredemmott
Differential Revision: D29018377
fbshipit-source-id: b4b1369d0f5875d3349df1930c876208f88f01e4
| hphp/runtime/ext/facts/config.cmake | diffblobblamehistory | |
| hphp/runtime/ext/facts/ext_facts.cpp | diffblobblamehistory | |
| hphp/runtime/ext/facts/facts-store.cpp | [new file with mode: 0644] | blob |
| hphp/runtime/ext/facts/facts-store.h | [new file with mode: 0644] | blob |
| hphp/runtime/ext/facts/watchman-autoload-map.cpp | [deleted file] | blobblamehistory |
| hphp/runtime/ext/facts/watchman-autoload-map.h | [deleted file] | blobblamehistory |