Eliminate Typing_env.get_options in favor of Typing_env.get_tcopt
commit58cac02c2be65cac9117b3a9290bacb2996e2427
authorSasha Manzyuk <manzyuk@fb.com>
Wed, 7 Nov 2018 18:24:59 +0000 (7 10:24 -0800)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Wed, 7 Nov 2018 18:28:17 +0000 (7 10:28 -0800)
tree7f8a5f862726fe462bf2bbd51d72ce250bcfb96f
parentbeb459552d2b8555c95cc6056c64c990e6f18c76
Eliminate Typing_env.get_options in favor of Typing_env.get_tcopt

Summary: We have two functions in `Typing_env` with identical implementation: `get_tcopt` and `get_options`.  I prefer the name `get_tcopt` (because the function returns **type-checker** options and because the implementation accesses the record field called `tcopt`), so let us eliminate `get_options`.

Reviewed By: andrewjkennedy

Differential Revision: D12956679

fbshipit-source-id: c9a87e8a02a9a56d2a90ab12be06c55d9e936dda
14 files changed:
hphp/hack/src/typing/nastCheck.ml
hphp/hack/src/typing/typing.ml
hphp/hack/src/typing/typing_env.ml
hphp/hack/src/typing/typing_env.mli
hphp/hack/src/typing/typing_func_terminality.ml
hphp/hack/src/typing/typing_lambda_ambiguous.ml
hphp/hack/src/typing/typing_log.ml
hphp/hack/src/typing/typing_print.ml
hphp/hack/src/typing/typing_reactivity.ml
hphp/hack/src/typing/typing_shapes.ml
hphp/hack/src/typing/typing_subtype.ml
hphp/hack/src/typing/typing_unify.ml
hphp/hack/src/typing/typing_union.ml
hphp/hack/src/typing/typing_utils.ml