| commit | 57ed0cf7dbd64b738d25ca6786e298067ea2cfc4 | |
| author | Edwin Smith <smith@fb.com> | |
| Sun, 19 Nov 2017 13:04:16 +0000 (19 05:04 -0800) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Tue, 21 Nov 2017 16:56:28 +0000 (21 08:56 -0800) | ||
| tree | 96ff3ac26d00a6f8ade667b965e89e997d768ead | treesnapshot (tar.gz zip) |
| parent | f3bbe366578bd93fca7e6c23cff2c69773193b93 | commitdiff |
Handle SetArray in ReleaseUncountedTv
Summary:
ReleaseUncountedTv() is called recursively to free items within
Uncounted arrays, but it didn't handle Keyset, and crashed when
such a key was stored in apc and then deleted/treadmilled.
Reviewed By: ricklavoie
Differential Revision: D6366666
fbshipit-source-id: bb796ac98d5199e923decc14bc61013f5a7941e2
Summary:
ReleaseUncountedTv() is called recursively to free items within
Uncounted arrays, but it didn't handle Keyset, and crashed when
such a key was stored in apc and then deleted/treadmilled.
Reviewed By: ricklavoie
Differential Revision: D6366666
fbshipit-source-id: bb796ac98d5199e923decc14bc61013f5a7941e2
| hphp/runtime/base/mixed-array-defs.h | diffblobblamehistory | |
| hphp/runtime/base/set-array.h | diffblobblamehistory | |
| hphp/test/slow/apc/apc-dict-keyset.php | [new file with mode: 0644] | blob |
| hphp/test/slow/apc/apc-dict-keyset.php.expect | [new file with mode: 0644] | blob |