A representative subset of errors that currently appear on declarations, but maybe...
commit57bf7b5c8953ca64ee6fd14412c9258ae6558870
authorMatt Schellhas <rms@fb.com>
Tue, 6 Aug 2019 23:21:07 +0000 (6 16:21 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Tue, 6 Aug 2019 23:27:22 +0000 (6 16:27 -0700)
tree55395cf23e0a95e65b03ffec0512cf41b484f915
parent24899d2d11a6d5e8b93045ae4d5280fb6aacba0c
A representative subset of errors that currently appear on declarations, but maybe shouldn't

Summary:
Currently many of our errors appear on class/interface/trait declarations, rather than the members that cause them. This made it easier to suppress bad classes in the past, but now that hack is more mature it's making it harder to categorize and programmatically solve the remaining issues.

This adds some tests so we can try to split that up confidently.

Reviewed By: DavidSnider

Differential Revision: D16612542

fbshipit-source-id: 29022008d1900323aa717e68eb6ce7551583268f
23 files changed:
hphp/hack/test/typecheck/new_type_errors/error_relocation/HH_FLAGS [new file with mode: 0644]
hphp/hack/test/typecheck/new_type_errors/error_relocation/ambiguous_inheritance.php [new file with mode: 0644]
hphp/hack/test/typecheck/new_type_errors/error_relocation/ambiguous_inheritance.php.exp [new file with mode: 0644]
hphp/hack/test/typecheck/new_type_errors/error_relocation/ambiguous_inheritance.php.like_types.exp [new file with mode: 0644]
hphp/hack/test/typecheck/new_type_errors/error_relocation/bad_inout_decl_parent1.php [new file with mode: 0644]
hphp/hack/test/typecheck/new_type_errors/error_relocation/bad_inout_decl_parent1.php.exp [new file with mode: 0644]
hphp/hack/test/typecheck/new_type_errors/error_relocation/bad_inout_decl_parent1.php.like_types.exp [new file with mode: 0644]
hphp/hack/test/typecheck/new_type_errors/error_relocation/bad_subclass.php [new file with mode: 0644]
hphp/hack/test/typecheck/new_type_errors/error_relocation/bad_subclass.php.exp [new file with mode: 0644]
hphp/hack/test/typecheck/new_type_errors/error_relocation/bad_subclass.php.like_types.exp [new file with mode: 0644]
hphp/hack/test/typecheck/new_type_errors/error_relocation/constraint_override_bad.php [new file with mode: 0644]
hphp/hack/test/typecheck/new_type_errors/error_relocation/constraint_override_bad.php.exp [new file with mode: 0644]
hphp/hack/test/typecheck/new_type_errors/error_relocation/constraint_override_bad.php.like_types.exp [new file with mode: 0644]
hphp/hack/test/typecheck/new_type_errors/error_relocation/enforceable_type_consts.php [new file with mode: 0644]
hphp/hack/test/typecheck/new_type_errors/error_relocation/enforceable_type_consts.php.exp [new file with mode: 0644]
hphp/hack/test/typecheck/new_type_errors/error_relocation/enforceable_type_consts.php.legacy_decl.exp [new file with mode: 0644]
hphp/hack/test/typecheck/new_type_errors/error_relocation/enforceable_type_consts.php.like_types.exp [new file with mode: 0644]
hphp/hack/test/typecheck/new_type_errors/error_relocation/fc_enum_non_arraykey_constraint.php [new file with mode: 0644]
hphp/hack/test/typecheck/new_type_errors/error_relocation/fc_enum_non_arraykey_constraint.php.exp [new file with mode: 0644]
hphp/hack/test/typecheck/new_type_errors/error_relocation/fc_enum_non_arraykey_constraint.php.like_types.exp [new file with mode: 0644]
hphp/hack/test/typecheck/new_type_errors/error_relocation/where_override_bad.php [new file with mode: 0644]
hphp/hack/test/typecheck/new_type_errors/error_relocation/where_override_bad.php.exp [new file with mode: 0644]
hphp/hack/test/typecheck/new_type_errors/error_relocation/where_override_bad.php.like_types.exp [new file with mode: 0644]