| commit | 57b743d4c9080d95bbf00f73592ea589151a3a02 | |
| author | qigao <gao@fb.com> | |
| Tue, 19 Jul 2011 17:57:54 +0000 (19 10:57 -0700) | ||
| committer | macvicar <macvicar@fb.com> | |
| Tue, 19 Jul 2011 19:24:25 +0000 (19 12:24 -0700) | ||
| tree | eeaa6725135606aae9b7b3176e2645f45b28ccc7 | treesnapshot (tar.gz zip) |
| parent | ab0fd44a3890246715ae36cb0c545c808c60a705 | commitdiff |
[Fix] Fix the problem hphpd stuck in code mode after done
Summary:
When we finish the code input mode, we run processEval() which changes
the inputState after running Eval. That's a problem because if we hit a
breakpoint during Eval, the inputState is not properly switched to
TakingCommand. This diff switches the order.
Test Plan:
make fast_tests
manually try a small case like the one described in the task
Reviewed By: myang
Reviewers: myang, mwilliams
CC: ps, mwilliams, myang
Revert Plan:
Tags:
- begin *PUBLIC* platform impact section -
Bugzilla: #
- end platform impact -
Differential Revision: 285535
Task ID: 639232
Summary:
When we finish the code input mode, we run processEval() which changes
the inputState after running Eval. That's a problem because if we hit a
breakpoint during Eval, the inputState is not properly switched to
TakingCommand. This diff switches the order.
Test Plan:
make fast_tests
manually try a small case like the one described in the task
Reviewed By: myang
Reviewers: myang, mwilliams
CC: ps, mwilliams, myang
Revert Plan:
Tags:
- begin *PUBLIC* platform impact section -
Bugzilla: #
- end platform impact -
Differential Revision: 285535
Task ID: 639232
| src/runtime/eval/debugger/debugger_client.cpp | diffblobblamehistory |