removing stream_errors flag: remove branching on flag + dead code
commit570d345e6e60b6f48bbe70f45b0c4efbb2a46a99
authorCatherine Gasnier <catg@fb.com>
Fri, 28 Jan 2022 16:46:46 +0000 (28 08:46 -0800)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Fri, 28 Jan 2022 16:48:30 +0000 (28 08:48 -0800)
treed5f706a2326fed4e4dd06a12b76a20ff89fd44e3
parent7dbfebe6b8ef4210c289f67191b9f7d6bb15d3e0
removing stream_errors flag: remove branching on flag + dead code

Summary:
Error streaming has now been rolled out everywhere, this diff stack cleans up the legacy  code. This first diff remove the branching on the flag plus some of the dead code.

The SUBSCRIBE_DIAGNOSTIC command is also not used with error streaming so we delete it and all associated code.

Reviewed By: ljw1004

Differential Revision: D33635223

fbshipit-source-id: bcec5181e1a76bc289e231ac30447e54226ef303
33 files changed:
hphp/hack/src/client/clientLsp.ml
hphp/hack/src/server/diagnostic_pusher.ml
hphp/hack/src/server/diagnostic_pusher.mli
hphp/hack/src/server/serverCommand.ml
hphp/hack/src/server/serverCommandTypes.ml
hphp/hack/src/server/serverCommandTypesUtils.ml
hphp/hack/src/server/serverMain.ml
hphp/hack/src/server/serverRpc.ml
hphp/hack/src/server/serverTypeCheck.ml
hphp/hack/src/typing/typing_check_service.ml
hphp/hack/test/integration/test_lsp.py
hphp/hack/test/integration_ml/dune
hphp/hack/test/integration_ml/ide/test_added_parent_ide.ml
hphp/hack/test/integration_ml/ide/test_diagnostics_in_closed_file.ml
hphp/hack/test/integration_ml/ide/test_error_pos.ml
hphp/hack/test/integration_ml/ide/test_error_throttling.ml
hphp/hack/test/integration_ml/ide/test_error_throttling_open_file.ml
hphp/hack/test/integration_ml/ide/test_failed_naming_ide.ml
hphp/hack/test/integration_ml/ide/test_failed_parsing.ml
hphp/hack/test/integration_ml/ide/test_ide_check.ml
hphp/hack/test/integration_ml/ide/test_ide_close.ml
hphp/hack/test/integration_ml/ide/test_ide_diagnostic_subscription.ml
hphp/hack/test/integration_ml/ide/test_ide_disk.ml
hphp/hack/test/integration_ml/ide/test_ide_parsing_errors.ml
hphp/hack/test/integration_ml/ide/test_ide_redecl.ml
hphp/hack/test/integration_ml/ide/test_ide_status.ml
hphp/hack/test/integration_ml/ide/test_ide_typing_deps.ml
hphp/hack/test/integration_ml/ide/test_naming_errors.ml
hphp/hack/test/integration_ml/ide/test_override.ml
hphp/hack/test/integration_ml/ide/test_remove_function.ml
hphp/hack/test/integration_ml/ide/test_remove_parent.ml
hphp/hack/test/integration_ml/integration_test_base.ml
hphp/hack/test/integration_ml/integration_test_base.mli