make pc a Set instead of a list
commit55e31688af9f2d4d340eea4e02fe8c59bec46285
authorNoam Zilberstein <noamz@fb.com>
Thu, 9 Jul 2020 14:40:58 +0000 (9 07:40 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Thu, 9 Jul 2020 14:42:53 +0000 (9 07:42 -0700)
tree769fe9f4c28a81120be644cab2262e29b440ecb5
parent2641b77f675cf554fa4347484382860f1939944d
make pc a Set instead of a list

Summary: We often need to accumulate elements into the PC. Using a list is inefficient because we will end up adding the same element many times. Switching to a Set will ensure that it contains the minimal number of elements needed

Reviewed By: mpu

Differential Revision: D22411355

fbshipit-source-id: c9956de017ead8baf0e1a1820f5c3be78d237a1a
hphp/hack/src/ifc/ifc.ml
hphp/hack/src/ifc/ifc_env.ml
hphp/hack/src/ifc/ifc_pretty.ml
hphp/hack/src/ifc/ifc_types.ml
hphp/hack/test/ifc/analysis/calls_basics.php.exp
hphp/hack/test/ifc/analysis/early_return.php.exp