break down Typing_extends.check_members
commit5586f99da93323b87c28001059fab6c4a1d2ec28
authorCatherine Gasnier <catg@fb.com>
Mon, 6 Dec 2021 17:09:08 +0000 (6 09:09 -0800)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Mon, 6 Dec 2021 17:10:52 +0000 (6 09:10 -0800)
tree58db447ada26e021123507dda94b391a3adff785
parentebfa48f35e0eb134791a8b3109c5615d43202097
break down Typing_extends.check_members

Summary:
We break it down in multiple helper calls to make it more visible what it's doing.
We introduce two new helper functions: add_member_dep and check_inherited_member_is_dynamically_callable, see inline comments.

Reviewed By: andrewjkennedy

Differential Revision: D32881638

fbshipit-source-id: 9a857e50c67fddfb80147aefd0f61f3788fe9220
hphp/hack/src/typing/typing_extends.ml