Fixing local variable completion inside class methods
commit5545ea866e226b4b6c148e47017009394ab49eaa
authorPhillip Shih <philshih@fb.com>
Fri, 11 Aug 2017 22:10:45 +0000 (11 15:10 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Fri, 11 Aug 2017 22:48:59 +0000 (11 15:48 -0700)
tree6be099cb10e3616c037ece9b7592b845d9da2784
parent4bb518d0be06ad894ede3048b7a609d98b38e453
Fixing local variable completion inside class methods

Summary:
- Lambda_analyzer did not pick up variables inside methods before
- Remove the variable that is what we are currently typing from the list of suggestions for a better user experience

Reviewed By: arxanas

Differential Revision: D5567556

fbshipit-source-id: 3427b00e4ecd18a4386984dda4c267e227e25880
hphp/hack/src/parser/lambda_analyzer.ml
hphp/hack/src/server/ffpAutocompleteLocalNames.ml
hphp/hack/test/ffp_autocomplete/local_variable_autocomplete/inside_class_method.php [new file with mode: 0644]
hphp/hack/test/ffp_autocomplete/local_variable_autocomplete/inside_class_method.php.exp [new file with mode: 0644]
hphp/hack/test/ffp_autocomplete/local_variable_autocomplete/local_variable_test.php.exp