ClsMeth type comparison improvement
commit5533d9a69fb7d628b2573236fb8dba72269fa635
authorYu-Jung Lo <ylo@fb.com>
Mon, 16 Sep 2019 23:57:10 +0000 (16 16:57 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Tue, 17 Sep 2019 00:00:36 +0000 (16 17:00 -0700)
treec6ee73ac597d87f71c304cf5b8a8cd0d7ee62e90
parentdcd3710a0ade77c1e50fe8f1945e7368e374829e
ClsMeth type comparison improvement

Summary:
* Raise notice when actually doing a clsmeth to vec/array conversion
* Implement ClsMeth comparison at JIT instead of punting to interpreter.

Reviewed By: ricklavoie

Differential Revision: D17276735

fbshipit-source-id: 854b8bf1dbdbb085086ea60bb6ba633589679317
hphp/runtime/base/builtin-functions.cpp
hphp/runtime/base/builtin-functions.h
hphp/runtime/base/tv-comparisons.cpp
hphp/runtime/vm/jit/irgen-arith.cpp
hphp/test/slow/global_func/class_meth/cmp.php
hphp/test/slow/global_func/class_meth/cmp.php.expectf
hphp/test/slow/global_func/class_meth/dv_arr_hack_arr/cmp_warn.php.expectf