| commit | 54bfde5a218786e3fa612e89997c259de3cfc841 | |
| author | bsimmers <bsimmers@fb.com> | |
| Tue, 2 Dec 2014 19:26:54 +0000 (2 11:26 -0800) | ||
| committer | hhvm-bot <hhvm-bot@fb.com> | |
| Thu, 4 Dec 2014 20:30:42 +0000 (4 12:30 -0800) | ||
| tree | 305fe8da14e31ec15733af865562a3372a8d6508 | treesnapshot (tar.gz zip) |
| parent | 99e752fbd00a47e68d2479ec08c29c3bfa4128a0 | commitdiff |
Eliminate some stores in pushVMState
Summary: gcc wasn't able to do this optimization automatically, so it was
writing the VMState object to the stack then copying it to the TinyVector. I also
tried adding emplace_back() to TinyVector and using that, but the generated
code wasn't quite as compact as this solution.
This makes VM reentry cheaper and reduces (but doesn't eliminate) the effect of
D1665434.
Reviewed By: @jasone
Differential Revision: D1713106
Summary: gcc wasn't able to do this optimization automatically, so it was
writing the VMState object to the stack then copying it to the TinyVector. I also
tried adding emplace_back() to TinyVector and using that, but the generated
code wasn't quite as compact as this solution.
This makes VM reentry cheaper and reduces (but doesn't eliminate) the effect of
D1665434.
Reviewed By: @jasone
Differential Revision: D1713106
| hphp/runtime/vm/bytecode.cpp | diffblobblamehistory | |
| hphp/runtime/vm/jit/irgen-minstr.cpp | diffblobblamehistory | |
| hphp/util/tiny-vector.h | diffblobblamehistory |