Make "String length exceeded" fatal consistent and correct.
commit54a894318e16fd7e093f1eb942a0866b7a3923ab
authorAlexey Toptygin <alexeyt@fb.com>
Mon, 24 Apr 2017 16:01:28 +0000 (24 09:01 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Mon, 24 Apr 2017 16:08:25 +0000 (24 09:08 -0700)
tree1aed7b2a24f31296005e22422518997ba5b4f56a
parent551532283b75d03c0a2a8a866a6d35ca139b1191
Make "String length exceeded" fatal consistent and correct.

Summary: Merge different ways of producing a "String length exceeded" fatal into one helper, and make the error message reflect the actual limit.

Reviewed By: markw65

Differential Revision: D4893949

fbshipit-source-id: 13b7018976de61c1d85d0152b9de4fa69c05241a
13 files changed:
hphp/runtime/base/string-data.cpp
hphp/runtime/base/string-data.h
hphp/runtime/base/string-util.cpp
hphp/runtime/ext/string/ext_string.cpp
hphp/test/slow/ext_string/chunk_split_overflow.php.expectf
hphp/test/slow/string/escapeshellarg.php.expectf
hphp/test/slow/string/quoted_printable.php.expectf
hphp/test/slow/string/urlencode.php.expectf
hphp/test/slow/string_length_overflow/fread.php.expectf
hphp/test/slow/string_length_overflow/implode.php.expectf
hphp/test/slow/string_length_overflow/nzuncompress.php.expectf
hphp/test/slow/string_length_overflow/thrift.php.expectf
hphp/test/slow/string_length_overflow/utf8_encode.php.expectf