Disallow Await and inout counting as a final position and ignore & as a lval-as-an...
commit545a9b2a12411b36c2b8ce8af6a4815572a4600c
authorKendall Hopkins <kendallhopkins@fb.com>
Sun, 7 Apr 2019 19:18:27 +0000 (7 12:18 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Sun, 7 Apr 2019 19:27:54 +0000 (7 12:27 -0700)
tree9ee222a16537b6546426d5c9ffe6808c6fbcd5fe
parent1a45f5450bf1bfd5e8900f8ae79cc98089be4a4f
Disallow Await and inout counting as a final position and ignore & as a lval-as-an-expression

Summary:
Because we don't support `async` and `inout` on the same function, we shouldn't support it as a final position.

Also because &'s are slanted for removal and hack has traditionally had a firm belief they don't exist I'm going to exclude them from being counted as `lval-as-an-expression`.

Reviewed By: Matt-Schellhas

Differential Revision: D14789082

fbshipit-source-id: 7d23d77bd84f4ae976a59528588f0b7a05badb0c
hphp/hack/src/parser/full_fidelity_parser_errors.ml
hphp/hack/test/full_fidelity/cases/concurrent/error/concurrent_reuse_lval_3.php [deleted file]
hphp/hack/test/full_fidelity/cases/concurrent/error/concurrent_reuse_lval_3.php.errors.exp [deleted file]
hphp/hack/test/full_fidelity/cases/concurrent/error/concurrent_reuse_lval_3.php.sexp.exp [deleted file]
hphp/hack/test/full_fidelity/cases/lval_as_an_expression/error/lval_as_an_expression_simple_error.php
hphp/hack/test/full_fidelity/cases/lval_as_an_expression/error/lval_as_an_expression_simple_error.php.errors.exp
hphp/hack/test/full_fidelity/cases/lval_as_an_expression/error/lval_as_an_expression_simple_error.php.sexp.exp
hphp/hack/test/full_fidelity/cases/lval_as_an_expression/lval_as_an_expression_simple.php
hphp/hack/test/full_fidelity/cases/lval_as_an_expression/lval_as_an_expression_simple.php.sexp.exp