Use req:: containers in ext_std_options
commit53d8ca60b43517b22e1483834636cc8818171d5e
authorEdwin Smith <smith@fb.com>
Tue, 13 Jun 2017 12:45:26 +0000 (13 05:45 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Tue, 13 Jun 2017 13:10:28 +0000 (13 06:10 -0700)
tree693de4987e3b9cb7c37c7cdab7936c5a510a86ea
parenta071c87d44be3515d2aacc0b4d466d96da9a8956
Use req:: containers in ext_std_options

Summary:
* Upgrade a bunch of memory management from req::malloc+realloc
  to req::vector.
* s/NULL/nullptr
* remove the dead first argument (argc) to php_opt_error()
* convert calls to std::strdup to req::strdup; the c-strings
  are clearly request-scoped.
* in php_canonicalize_version(), use req::malloc_noptrs() instead
  of std::malloc().

Reviewed By: alexeyt

Differential Revision: D5144109

fbshipit-source-id: 512871b8e460031d028b610202bc2a3c247360a1
hphp/runtime/base/req-malloc.h
hphp/runtime/ext/std/ext_std_options.cpp