| commit | 51e35e1bd69217316e4e48111053b7649690a047 | |
| author | Paul Bissonnette <paulbiss@fb.com> | |
| Mon, 27 Aug 2018 15:57:17 +0000 (27 08:57 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Mon, 27 Aug 2018 16:13:12 +0000 (27 09:13 -0700) | ||
| tree | 764009927be6878088bc3da4a2a7351e450d0785 | treesnapshot (tar.gz zip) |
| parent | 0779e0a5058fcea3569648175b9e04ea2a4d26ff | commitdiff |
Fix simplifier assertion
Summary: This should be safe, if the output Tmp from CreateSSWH is available then so is its input. I think a cleaner fix here would be to move this logic to load-elim and add a memory-effect for creating a SSWH, it would probably expose more opportunities for this to kick in too.
Reviewed By: ricklavoie
Differential Revision: D9512595
fbshipit-source-id: 26e223beaadc1a7454bf39f7797b16e44472f233
Summary: This should be safe, if the output Tmp from CreateSSWH is available then so is its input. I think a cleaner fix here would be to move this logic to load-elim and add a memory-effect for creating a SSWH, it would probably expose more opportunities for this to kick in too.
Reviewed By: ricklavoie
Differential Revision: D9512595
fbshipit-source-id: 26e223beaadc1a7454bf39f7797b16e44472f233
| hphp/runtime/vm/jit/simplify.cpp | diffblobblamehistory |