| commit | 51431335d2ece7eabb6961f49ad7e4cfd351d40b | |
| author | Kunal Mehta <kunalm@fb.com> | |
| Wed, 17 Jul 2019 07:12:55 +0000 (17 00:12 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Wed, 17 Jul 2019 07:16:39 +0000 (17 00:16 -0700) | ||
| tree | a23ce68fc66ffa410d93e35871edd6800e11eabd | treesnapshot (tar.gz zip) |
| parent | 2288d40862bc6286d95f280873ecaddfce0c67e1 | commitdiff |
Unban reification of dynamic and functions
Summary:
Recent changes to the runtime have allowed us to unban these types:
- `dynamic` now reifies differently from `mixed`
- Reification behavior and optimizations were implemented for functions.
We must still ban functions with variadic args for now, since that is not reflected in the type structure. I'm investigating the viability of banning the `...` syntax in Hack, so that function typehints must have a typehint for their variadic arg. That will make implementation of variadic args in type structures simpler.
Reviewed By: vassilmladenov
Differential Revision: D16229007
fbshipit-source-id: cc02c443b08704de5fa83fbbf2b2d5e80ffb59d3
Summary:
Recent changes to the runtime have allowed us to unban these types:
- `dynamic` now reifies differently from `mixed`
- Reification behavior and optimizations were implemented for functions.
We must still ban functions with variadic args for now, since that is not reflected in the type structure. I'm investigating the viability of banning the `...` syntax in Hack, so that function typehints must have a typehint for their variadic arg. That will make implementation of variadic args in type structures simpler.
Reviewed By: vassilmladenov
Differential Revision: D16229007
fbshipit-source-id: cc02c443b08704de5fa83fbbf2b2d5e80ffb59d3