Trailing comma cases in FFP
commit50d383850ecb483efd0ef21a32e07907a743807f
authorPhilip Hölzenspies <drphil@fb.com>
Fri, 7 Jul 2017 18:25:02 +0000 (7 11:25 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Fri, 7 Jul 2017 18:29:27 +0000 (7 11:29 -0700)
tree4111ff7c2b18d618a3fe4e7bbe6e3179ddc9b1b0
parentb16545e6b75034467724839244aa093b8c7c0c1c
Trailing comma cases in FFP

Summary:
The Full Fidelity Parser does not allow for trailing commas in some builtin cases, like `dict<int,string,>`. These trailing comma's hardly have a place there, but for consistent style guides, and such, support for them seems desired.

Also added missing cases to `hack_fmt` and the pretty printer (trailing commas in `Vector` type specifiers).

Differential Revision: D5370546

fbshipit-source-id: 53c6a16a89bf6d3cfba38cd1a10e4d21258a24db
15 files changed:
hphp/hack/src/hackfmt/hack_format.ml
hphp/hack/src/parser/full_fidelity_ast.ml
hphp/hack/src/parser/full_fidelity_positioned_syntax.ml
hphp/hack/src/parser/full_fidelity_pretty_printer.ml
hphp/hack/src/parser/full_fidelity_syntax.ml
hphp/hack/src/parser/full_fidelity_syntax_type.ml
hphp/hack/src/parser/full_fidelity_type_parser.ml
hphp/hack/src/parser/full_fidelity_validated_syntax.ml
hphp/hack/src/parser/js/full_fidelity_editable.js
hphp/hack/src/parser/js/full_fidelity_schema.json
hphp/hack/src/parser/php/full_fidelity_editable.php
hphp/hack/src/parser/schema/schema_definition.ml
hphp/hack/test/full_fidelity/cases/test_trailing_commas.exp [new file with mode: 0644]
hphp/hack/test/full_fidelity/cases/test_trailing_commas.php [new file with mode: 0644]
hphp/hack/test/full_fidelity/full_fidelity_unit_test.ml