Fix bugs in class-ptr warnings
commit4d6d53308968bd1d4c98ff3720816fdb32e8aaf8
authorMichael Colavita <mcolavita@fb.com>
Mon, 2 Nov 2020 17:21:31 +0000 (2 09:21 -0800)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Mon, 2 Nov 2020 17:25:57 +0000 (2 09:25 -0800)
treeecc821ce34a950372c234c255268bff9eee4a8d4
parentc39274cd5683a84f71c32507409ca09299185c3b
Fix bugs in class-ptr warnings

Summary: I found a few more bugs in the class-ptr warning code while enabling expanding our RTA test suite. I have resolved the remaining issues and added an assertion to make sure this doesn't crop up again.

Differential Revision: D24677092

fbshipit-source-id: a80932840ee256d3803fda75e1787c32279f9a1e
hphp/runtime/vm/jit/irgen-builtin.cpp
hphp/runtime/vm/jit/irgen-internal.cpp