Move var_dump() to HNI, kill off variable.idl.json
commit4d5a3113188988a0ee27f48c7af9887936297016
authorSara Golemon <sgolemon@fb.com>
Mon, 25 Aug 2014 22:33:56 +0000 (25 15:33 -0700)
committerhhvm-bot <hhvm-bot@fb.com>
Mon, 25 Aug 2014 23:00:27 +0000 (25 16:00 -0700)
tree436d1383d570e0f9ebac57da87dfa15673993403
parentf5ac0822559258b94ac2d04d6c57e133e46ae8c4
Move var_dump() to HNI, kill off variable.idl.json

Summary: Note that this modifies xdebug code-coverage behavior.

Our xdebug implementation doesn't profile IDL based
builtins, but it does happily profile HNI based ones.

It *should* profile all IDL based functions,
so that'll have to be fixed in a followup,
but for now I've re-recorded the effected xdebug tests
to provide the correct results.

Reviewed By: @ptarjan

Differential Revision: D1515818
hphp/runtime/base/program-functions.cpp
hphp/runtime/ext/std/ext_std_variable.cpp
hphp/runtime/ext/std/ext_std_variable.h
hphp/runtime/ext/std/ext_std_variable.php
hphp/system/idl/variable.idl.json [deleted file]
hphp/test/ext/test_base.cpp
hphp/test/slow/ext_xdebug/code_coverage_started.php.expectf
hphp/test/slow/ext_xdebug/get_code_coverage.php.expectf
hphp/test/slow/ext_xdebug/profiling_tester.php.expectf
hphp/test/slow/ext_xdebug/remote_step_over.php.expectf
hphp/test/slow/ext_xdebug/remote_step_over.test.in