| commit | 4ac50f8b57ac36ed0f6a4117d10c5578f5796c14 | |
| author | Kevin Viratyosin <viratyosin@fb.com> | |
| Mon, 19 Sep 2022 22:09:26 +0000 (19 15:09 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Mon, 19 Sep 2022 22:09:26 +0000 (19 15:09 -0700) | ||
| tree | ef6f4aa581835b8c082565c88a801005014ed395 | treesnapshot (tar.gz zip) |
| parent | 6679a6d31a686a022ca431894fdde92be719290e | commitdiff |
Remove policy_sharded param from Typing_memoize.check_param
Summary:
This was added in D35834057 (https://github.com/facebook/hhvm/commit/bff230633294553e7ff932e04709dabc06561066) where it gated calling Typing_local_ops.enforce_memoize_object which, at the time, just checked for `globals` -- policy-sharded memoization bypassed this requirement (and was only allowed for zoned); However, after D36680535 (https://github.com/facebook/hhvm/commit/5b39f1087ab7fdc4d897ddc193c0e9c90dd70d7a), that callee now checks for `zoned` or `globals` which makes it appropriate for `zoned` too. So now there's no need to gate the check.
Also, since switching to `__Memoize(#KeyedByIC)` the callers passing this param were kinda broken anyway.
Reviewed By: oulgen
Differential Revision: D39630079
fbshipit-source-id: d6f416e104fedefae20c117f453b12121e9cdc28
Summary:
This was added in D35834057 (https://github.com/facebook/hhvm/commit/bff230633294553e7ff932e04709dabc06561066) where it gated calling Typing_local_ops.enforce_memoize_object which, at the time, just checked for `globals` -- policy-sharded memoization bypassed this requirement (and was only allowed for zoned); However, after D36680535 (https://github.com/facebook/hhvm/commit/5b39f1087ab7fdc4d897ddc193c0e9c90dd70d7a), that callee now checks for `zoned` or `globals` which makes it appropriate for `zoned` too. So now there's no need to gate the check.
Also, since switching to `__Memoize(#KeyedByIC)` the callers passing this param were kinda broken anyway.
Reviewed By: oulgen
Differential Revision: D39630079
fbshipit-source-id: d6f416e104fedefae20c117f453b12121e9cdc28
| hphp/hack/src/typing/typing_memoize.ml | diffblobblamehistory |