Rename and document some vaguely svcreq-related things
commit4a97869d8b69020e3d603300b78a79a9cab3eefb
authorMax Wang <mwang@fb.com>
Thu, 6 Aug 2015 07:12:54 +0000 (6 00:12 -0700)
committerhhvm-bot <hhvm-bot@fb.com>
Thu, 6 Aug 2015 08:02:16 +0000 (6 01:02 -0700)
treeeeb95a4f7fd718b9b3347ab9295cf966196d2522
parent0672eb1867c1fa6d63d902fd4640f6527fca5281
Rename and document some vaguely svcreq-related things

Summary: This diff contains no functional changes, just tidying up and
documentation in the wake of killing arch-dependent service requests.
Changes include:

- s/kJmpccLen/kJccLen/g

- Use `target' as the name of the to-be-translated SrcKey in all
  svcreq-related structures (namely, Vinstrs and ExtraDatas) instead of
  waffling between `target', `dest', and `sk'.
- Use a consistent order for service requests everywhere they're used
  (this will probably not last, but w/e).

- Organize and document the vasm intrinsics better.
- Kill vret (it is never used), then rename vretm to vret.
- Rename callstub to callarray; it sounds similar to callfaststub but
  actually isn't.

- Document method cache priming coherently in one location.

Reviewed By: @edwinsmith

Differential Revision: D2291378
22 files changed:
hphp/runtime/vm/jit/back-end-x64.cpp
hphp/runtime/vm/jit/back-end-x64.h
hphp/runtime/vm/jit/code-gen-x64.cpp
hphp/runtime/vm/jit/code-gen.h
hphp/runtime/vm/jit/extra-data.h
hphp/runtime/vm/jit/ir-unit.cpp
hphp/runtime/vm/jit/mc-generator.cpp
hphp/runtime/vm/jit/reg-alloc.cpp
hphp/runtime/vm/jit/service-requests.cpp
hphp/runtime/vm/jit/service-requests.h
hphp/runtime/vm/jit/target-cache.h
hphp/runtime/vm/jit/vasm-check.cpp
hphp/runtime/vm/jit/vasm-dead.cpp
hphp/runtime/vm/jit/vasm-fusion.cpp
hphp/runtime/vm/jit/vasm-instr.cpp
hphp/runtime/vm/jit/vasm-instr.h
hphp/runtime/vm/jit/vasm-internal.cpp
hphp/runtime/vm/jit/vasm-jumps.cpp
hphp/runtime/vm/jit/vasm-llvm.cpp
hphp/runtime/vm/jit/vasm-x64.cpp
hphp/runtime/vm/jit/vasm-xls.cpp
hphp/runtime/vm/jit/vasm.cpp