| commit | 49fa4dd2affce27d2d38b44ed792e40123eb980e | |
| author | Vincent Siles <vsiles@fb.com> | |
| Fri, 17 Apr 2020 08:08:55 +0000 (17 01:08 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Fri, 17 Apr 2020 08:13:27 +0000 (17 01:13 -0700) | ||
| tree | 35e1845203c06d31f4f64b781eb5bd18351b7e12 | treesnapshot (tar.gz zip) |
| parent | fd05c958436f266c5f585e5ba3809e64ce1a838a | commitdiff |
move PU translation outside of `emit`
Summary:
Because of Naming, the nast/tast dumped by hh_single_type_check is not the same
as the one used by compilation.
I'm thinking of adding an option to {hh_,}single_compile to dump the ast
before code emittion, so I'm moving PU translation outside of the `emit`
function to make things nicer
Reviewed By: shiqicao, losvald
Differential Revision: D20963028
fbshipit-source-id: e53ea07677bd93832d76c0753775793b11493ba2
Summary:
Because of Naming, the nast/tast dumped by hh_single_type_check is not the same
as the one used by compilation.
I'm thinking of adding an option to {hh_,}single_compile to dump the ast
before code emittion, so I'm moving PU translation outside of the `emit`
function to make things nicer
Reviewed By: shiqicao, losvald
Differential Revision: D20963028
fbshipit-source-id: e53ea07677bd93832d76c0753775793b11493ba2
| hphp/hack/src/hhbc/compile.ml | diffblobblamehistory | |
| hphp/hack/src/hhbc/compile.rs | diffblobblamehistory |