| commit | 475d253b80bc2d97963b68c25ecdf2998a61ceaa | |
| author | Josh Watzman <jwatzman@fb.com> | |
| Mon, 2 Jun 2014 19:23:11 +0000 (2 12:23 -0700) | ||
| committer | JoelMarcey <joelm@fb.com> | |
| Mon, 2 Jun 2014 23:15:01 +0000 (2 16:15 -0700) | ||
| tree | ff5a1311d6ae8b747354594931a9f8414d2d1bb9 | treesnapshot (tar.gz zip) |
| parent | 67ed6a75637fb2b1335a2e191b7d58d82b3f75a6 | commitdiff |
Straighten out typedef checking
Summary: Right now we keep this `seen` map of typedefs we've expanded to check
for circularity. This doesn't work when expanding something like
`TD<TD<int>>` -- that's not necessarily circular, just involves the same
typedef more than once. Instead, track what the toplevel typedef name
is, and carry just that through when checking for circularity.
Fixes #2556 (https://github.com/facebook/hhvm/issues/2556)
Reviewed By: @pikatchu
Differential Revision: D1335495
Summary: Right now we keep this `seen` map of typedefs we've expanded to check
for circularity. This doesn't work when expanding something like
`TD<TD<int>>` -- that's not necessarily circular, just involves the same
typedef more than once. Instead, track what the toplevel typedef name
is, and carry just that through when checking for circularity.
Fixes #2556 (https://github.com/facebook/hhvm/issues/2556)
Reviewed By: @pikatchu
Differential Revision: D1335495
13 files changed: