simplify logic for `check_member_unique` param in Typing_extends
Summary:
Here's a summary of the code changes:
Before:
```
let check_multiple_concrete_definitions check_member_unique ... =
if check_member_unique && ... then ...
let check_override ~check_member_unique ... =
...
check_multiple_concrete_definitions check_member_unique ...
...
let foo ... =
check_override ~check_member_unique:false ...
let check_class_against_parent_class_elt ... =
...
check_override ~check_member_unique:(detect_multiple_concrete_defs ...)
...
```
After:
```
let check_multiple_concrete_definitions ... =
if detect_multiple_concrete_defs ... && ... then ...
let check_override ~check_member_unique ... =
...
if check_member_unique then
check_multiple_concrete_definitions ...
...
let foo ... =
check_override ~check_member_unique:false ...
let check_class_against_parent_class_elt ... =
...
check_override ~check_member_unique:true
...
```
I.o.w:
- We've replaced `check_member_unique` with its value in `check_multiple_concrete_definitions`
- `check_member_unique` is now guarding call to `check_multiple_concrete_definitions` in `check_override`
- Callers to `check_override` pass boolean literal as `check_member_unique` param.
Reviewed By: andrewjkennedy
Differential Revision:
D34893593
fbshipit-source-id:
c2236825b8455562cd8b374c2e1fca34305f4d87