| commit | 465841ae483a9598f4a104cd85395071260d26bd | |
| author | Jan Oravec <jan@fb.com> | |
| Fri, 8 Nov 2019 06:17:48 +0000 (7 22:17 -0800) | ||
| committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | |
| Fri, 8 Nov 2019 06:19:33 +0000 (7 22:19 -0800) | ||
| tree | 01918aa699fef5185dcf932845f09b5cd1a5e201 | treesnapshot (tar.gz zip) |
| parent | 3b5047b54ef021473f5f84cec2d3c0eed3e0d9dd | commitdiff |
Subsample perf warnings for SSATmp spanning across the calls
Summary:
This became super hot after mofarrell's diff that reuses the SSATmp for
`$this` or class ctx across the calls.
Let's subsample these perf warnings until ctx becomes a regular local and the
problem will go away (as we will be able to spill ctx into its actual slot
rather than to the native stack).
This also opens up an idea to split handling of values and types, so that we
can spill only the non-const value on the hot path and defer spilling the
statically known types to the cold paths.
Reviewed By: ricklavoie
Differential Revision: D18383131
fbshipit-source-id: a08379d639565c55f4a16d8b07d5cc81fc2e4502
Summary:
This became super hot after mofarrell's diff that reuses the SSATmp for
`$this` or class ctx across the calls.
Let's subsample these perf warnings until ctx becomes a regular local and the
problem will go away (as we will be able to spill ctx into its actual slot
rather than to the native stack).
This also opens up an idea to split handling of values and types, so that we
can spill only the non-const value on the hot path and defer spilling the
statically known types to the cold paths.
Reviewed By: ricklavoie
Differential Revision: D18383131
fbshipit-source-id: a08379d639565c55f4a16d8b07d5cc81fc2e4502
| hphp/runtime/vm/jit/check.cpp | diffblobblamehistory |