Replace ByteOffsetData with LvalOffsetData
commit4656f3984936422473196b0c9433a0c270808a5d
authorJoseph Griego <jgriego@fb.com>
Fri, 6 Dec 2019 16:12:10 +0000 (6 08:12 -0800)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Fri, 6 Dec 2019 16:18:20 +0000 (6 08:18 -0800)
tree6681f96b93ed996861a882a5bddc381582c6b2af
parent6395c5556e2204347df6dc40b8aa0a1380a835c0
Replace ByteOffsetData with LvalOffsetData

Summary:
There's a handful of IR opcodes that take a byte offset to a
particular lval in an object, but that's silly and we should explicitly pass
the offsets to both the type and value, since we're about to make those
disjoint for objects.

Differential Revision: D18643773

fbshipit-source-id: 5f7a33b53ba28a0a66c211ce7b9038fa2ff4967f
13 files changed:
hphp/doc/ir.specification
hphp/runtime/vm/class.cpp
hphp/runtime/vm/class.h
hphp/runtime/vm/jit/alias-class.h
hphp/runtime/vm/jit/extra-data.h
hphp/runtime/vm/jit/irgen-builtin.cpp
hphp/runtime/vm/jit/irgen-call.cpp
hphp/runtime/vm/jit/irgen-create.cpp
hphp/runtime/vm/jit/irgen-func-prologue.cpp
hphp/runtime/vm/jit/irgen-minstr.cpp
hphp/runtime/vm/jit/irlower-closure.cpp
hphp/runtime/vm/jit/irlower-load-store.cpp
hphp/runtime/vm/jit/memory-effects.cpp