| commit | 44988b111db9c9beb7a78b5303fe18f673f3747b | |
| author | Victor Zverovich <viz@fb.com> | |
| Tue, 27 Nov 2018 14:35:25 +0000 (27 06:35 -0800) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Tue, 27 Nov 2018 14:37:43 +0000 (27 06:37 -0800) | ||
| tree | 5054bd48a708336b5652a8b155a6fed8ecc50bcd | treesnapshot (tar.gz zip) |
| parent | 3f657fa0d49678e0647cdfd8313ca4b5d84377fb | commitdiff |
Improve debuggability of range check failures
Summary:
D10204561 added integer range checks to compact Thrift serializer with class and
field ID reported on failures. However, this only applied to scalar fields and
not lists or maps making debugging hard. This diff extends debugging information
to non-scalar fields.
Reviewed By: yfeldblum, alexeyt
Differential Revision: D13089943
fbshipit-source-id: 2cf89276622e458736eeef63474e54568dc8d2c0
Summary:
D10204561 added integer range checks to compact Thrift serializer with class and
field ID reported on failures. However, this only applied to scalar fields and
not lists or maps making debugging hard. This diff extends debugging information
to non-scalar fields.
Reviewed By: yfeldblum, alexeyt
Differential Revision: D13089943
fbshipit-source-id: 2cf89276622e458736eeef63474e54568dc8d2c0
| hphp/runtime/ext/thrift/compact.cpp | diffblobblamehistory | |
| hphp/test/slow/thrift/range_check.php | diffblobblamehistory | |
| hphp/test/slow/thrift/range_check.php.expectf | diffblobblamehistory |