| commit | 43c13deb3dfb53524563264c0d590df967cd64a2 | |
| author | Kasper Kopec <kasper@fb.com> | |
| Tue, 3 Jan 2017 23:51:00 +0000 (3 15:51 -0800) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Tue, 3 Jan 2017 23:52:36 +0000 (3 15:52 -0800) | ||
| tree | 30fbc25849396f328ac04e62e2d79b3b0a130e87 | treesnapshot (tar.gz zip) |
| parent | a775cb13103e62b1cdb2e968deba805b48458c41 | commitdiff |
JSON RPC version of autocomplete / didOpenFile messages
Summary:
The whole point of versions is to be able to make changes, while giving existing users time to adjust. Here is an example of introducing some changes to commands that are already in use:
- rename "contents" of DidOpenFileParams to "text" (for consistency with "text" field of TextEdit)
- remove deprecated fields ("variadic", "min_arity", "pos", "expected_ty") from autocomplete response
- rename func_details to callable_details in autocomplete reposnes (because "func" suggests only a function, and those can also be methods)
- rename getCompletions to autocomplete (consistency with naming in other places)
Reviewed By: jopamer
Differential Revision: D4315591
fbshipit-source-id: aa67c88ba68103add39120adbaba0b9f7b910ccf
Summary:
The whole point of versions is to be able to make changes, while giving existing users time to adjust. Here is an example of introducing some changes to commands that are already in use:
- rename "contents" of DidOpenFileParams to "text" (for consistency with "text" field of TextEdit)
- remove deprecated fields ("variadic", "min_arity", "pos", "expected_ty") from autocomplete response
- rename func_details to callable_details in autocomplete reposnes (because "func" suggests only a function, and those can also be methods)
- rename getCompletions to autocomplete (consistency with naming in other places)
Reviewed By: jopamer
Differential Revision: D4315591
fbshipit-source-id: aa67c88ba68103add39120adbaba0b9f7b910ccf