Remove Aast.TCPartiallyAbstract
commit4126b29970690b64ab171ffae6468c78bd4b1180
authorVassil Mladenov <vmladenov@fb.com>
Wed, 6 Oct 2021 18:51:58 +0000 (6 11:51 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Wed, 6 Oct 2021 18:53:29 +0000 (6 11:53 -0700)
tree9ee7d52c1cb6b68015f0715bb720734b3275e5e1
parent66981dcca6221a5bf9c5d4aeb4440bcc6f3bb844
Remove Aast.TCPartiallyAbstract

Summary: Removes the Aast structure for partially abstract type constants. Now, any constant without abstract lowers into `TCConcrete`. I moved the definition error to the parser but retained the code / error message as we may want to allow `as` constraints back on concrete type constants now that the concept of partially abstract type constants has been eliminated.

Reviewed By: andrewjkennedy

Differential Revision: D31328780

fbshipit-source-id: 923172c6dc0c7567ee1b5e894ee845eb2a8cb703
27 files changed:
hphp/hack/src/annotated_ast/aast.ml
hphp/hack/src/decl/shallow_decl.ml
hphp/hack/src/errors/errors.ml
hphp/hack/src/errors/errors.mli
hphp/hack/src/hhbc/hhbc_by_ref/emit_class.rs
hphp/hack/src/naming/naming.ml
hphp/hack/src/naming/naming_elaborate_namespaces_endo.ml
hphp/hack/src/naming/nast.ml
hphp/hack/src/oxidized/aast_visitor/node_impl_gen.rs
hphp/hack/src/oxidized/aast_visitor/node_mut_impl_gen.rs
hphp/hack/src/oxidized/aast_visitor/visitor.rs
hphp/hack/src/oxidized/aast_visitor/visitor_mut.rs
hphp/hack/src/oxidized/gen/aast.rs
hphp/hack/src/oxidized/impl_gen/aast_impl_gen.rs
hphp/hack/src/oxidized/manual/errors_impl.rs
hphp/hack/src/oxidized_by_ref/gen/aast.rs
hphp/hack/src/parser/lowerer/lowerer.rs
hphp/hack/src/server/serverExtractStandalone.ml
hphp/hack/src/typing/nast_check/class_tparams_check.ml
hphp/hack/src/typing/nast_check/interface_check.ml
hphp/hack/src/typing/tast_check/type_const_check.ml
hphp/hack/src/typing/typing_toplevel.ml
hphp/hack/src/typing/typing_type_wellformedness.ml
hphp/hack/src/typing/write_symbol_info/symbol_add_fact.ml
hphp/hack/src/typing/write_symbol_info/symbol_build_json.ml
hphp/hack/test/tast/typeconsts.php.exp
hphp/hack/test/typecheck/tconst/tconst_cstr.php.exp