| commit | 40796b2a91841fa4c4cc5d8b5990b478de2929f5 | |
| author | Catherine Gasnier <catg@fb.com> | |
| Fri, 12 Apr 2019 17:46:16 +0000 (12 10:46 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Fri, 12 Apr 2019 17:52:46 +0000 (12 10:52 -0700) | ||
| tree | 7853471d80f3de7fcb73ec7e42bc2521a4f0db95 | treesnapshot (tar.gz zip) |
| parent | c247cb65a81f425cb5b66d4fbde773e7af5a18e7 | commitdiff |
anonymous function should not capture variables not in 'use' clause.
Summary:
Currently, for lambdas and anonymous functions, we stash all continuations but Next. In this diff, we also stash the Next continuation for anonymous functions and reinject variables from the use clause.
This requires to add a boolean to Efun to tell whether that's an anonymous function (not fond of this solution because that adds up to the Lfun Efun mess, so any suggestion welcome).
There are also some not so interesting changes in the helper functions in Typing_env, Typing_lenv, Typing_lenv_cont.
Reviewed By: andrewjkennedy
Differential Revision: D14664890
fbshipit-source-id: d8b62b16ba169a3c285b7a14075c4be5692ec503
Summary:
Currently, for lambdas and anonymous functions, we stash all continuations but Next. In this diff, we also stash the Next continuation for anonymous functions and reinject variables from the use clause.
This requires to add a boolean to Efun to tell whether that's an anonymous function (not fond of this solution because that adds up to the Lfun Efun mess, so any suggestion welcome).
There are also some not so interesting changes in the helper functions in Typing_env, Typing_lenv, Typing_lenv_cont.
Reviewed By: andrewjkennedy
Differential Revision: D14664890
fbshipit-source-id: d8b62b16ba169a3c285b7a14075c4be5692ec503
30 files changed: