| commit | 40706d78f19a9dfe3df230bd04093ffed8e811e1 | |
| author | Daniel Neiter <dneiter@fb.com> | |
| Thu, 3 Oct 2019 17:21:35 +0000 (3 10:21 -0700) | ||
| committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | |
| Thu, 3 Oct 2019 17:24:23 +0000 (3 10:24 -0700) | ||
| tree | 248f18ee37af229ad914a0fad79c91fc2b058f7d | treesnapshot (tar.gz zip) |
| parent | 0a2379a49ff8ac87e3e699a4839f842458d40df2 | commitdiff |
Make inout parameters on magic methods a parser error
Summary:
We have explicit parser checks to disallow magic methods with byref parameters. When I tried updating these tests, I've discovered, we don't have similar checks against inout parameters on magic methods. Moreover, magic `__set(inout $name, value)` *seems* to work (i.e. the test runs successfuly and calls method, despite calling convention mismatch; I'm not sure if it violates any internal assumptions).
Add equivalent parser check to block inout parameters from magic methods.
Reviewed By: dabek
Differential Revision: D17728519
fbshipit-source-id: f979ecbb7c69647f425b36788e72e7446cfda17e
Summary:
We have explicit parser checks to disallow magic methods with byref parameters. When I tried updating these tests, I've discovered, we don't have similar checks against inout parameters on magic methods. Moreover, magic `__set(inout $name, value)` *seems* to work (i.e. the test runs successfuly and calls method, despite calling convention mismatch; I'm not sure if it violates any internal assumptions).
Add equivalent parser check to block inout parameters from magic methods.
Reviewed By: dabek
Differential Revision: D17728519
fbshipit-source-id: f979ecbb7c69647f425b36788e72e7446cfda17e
18 files changed: