"hh_server's version doesn't match the client's". -- SO TELL ME THE VERSION\!
commit405898e43fe2b7f29de75aa7d8912fdba82c7bdd
authorLucian Wischik <ljw@fb.com>
Tue, 16 May 2017 15:53:43 +0000 (16 08:53 -0700)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Tue, 16 May 2017 16:10:48 +0000 (16 09:10 -0700)
tree62112b74ec2998dbd7261bd4967ca6f2a521e69e
parent22a92ccf4003166f2e4fa95037cf4c38871aeace
"hh_server's version doesn't match the client's". -- SO TELL ME THE VERSION\!

Summary:
Currently in case of a version mismatch we get messages like this:

  hh_server's version doesn't match the client's, so it will exit.
  Going to launch a new one.
  Server launched with the following command:
    '/data/users/ljw/fbsource/fbcode/buck-out/dbg/gen/hphp/hack/src/hh_server/hh_server' '-d' '/data/users/ljw/www-hg' '--waiting-client' '11'
  Spawned typechecker (child pid=2112370)
  Logs will go to /tmp/hh_server/zSdatazSuserszSljwzSwww-hg.monitor_log

I've found it frustrating when I encounter these. It always wastes a load of time digging through logs. With this diff, it will display more information:

  hh_server '...path_to_hh_server' was launched 15 hours ago.

I hope that with the extra path information, it'll save time when diagnosing errors.

Reviewed By: alexchow

Differential Revision: D4967303

fbshipit-source-id: a79f3d8f39f3c5949e1a01c75f57067359273a63
hphp/hack/src/client/clientConnect.ml
hphp/hack/src/client/clientIde.ml
hphp/hack/src/client/clientLsp.ml
hphp/hack/src/client/clientStart.ml
hphp/hack/src/client/clientStop.ml
hphp/hack/src/monitor/monitorConnection.ml
hphp/hack/src/monitor/serverMonitor.ml
hphp/hack/src/monitor/serverMonitorUtils.ml