| commit | 4005bae7a5105cfbc242e70dfdd5e016e1255611 | |
| author | Michael Thomas <mjt@fb.com> | |
| Sat, 14 Aug 2021 22:45:46 +0000 (14 15:45 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Sat, 14 Aug 2021 22:47:07 +0000 (14 15:47 -0700) | ||
| tree | ac1f1962d50b0fc9b6a71590026a96c2aa63a7b6 | treesnapshot (tar.gz zip) |
| parent | 9b30dcabef2506d15bb45d6a27ef3130baae0f94 | commitdiff |
Generate distinct error when indexing covariant containers
Summary:
D29663090 (https://github.com/facebook/hhvm/commit/6e901314e9bd74462f45cf59bcb4493e52c5ee59) modified the TAST check on containers with covariant in their keys to be consistent with the treatment in typing, i.e. it is only an error if the indexing expression cannot be types as `arraykey`. Whilst correct, this allows indexing of, for example, a `dict<string,_>` with an `int` which will always fail.
This diff restores the previous behaviour but uses a distinct error code, 4449, CovariantIndexTypeMismatch, which still allows us to discern this case from (castable) type errors.
Reviewed By: hgoldstein
Differential Revision: D30281788
fbshipit-source-id: ee0ca2ac34ead6eea9316d27bcfbb1bc5a5955fd
Summary:
D29663090 (https://github.com/facebook/hhvm/commit/6e901314e9bd74462f45cf59bcb4493e52c5ee59) modified the TAST check on containers with covariant in their keys to be consistent with the treatment in typing, i.e. it is only an error if the indexing expression cannot be types as `arraykey`. Whilst correct, this allows indexing of, for example, a `dict<string,_>` with an `int` which will always fail.
This diff restores the previous behaviour but uses a distinct error code, 4449, CovariantIndexTypeMismatch, which still allows us to discern this case from (castable) type errors.
Reviewed By: hgoldstein
Differential Revision: D30281788
fbshipit-source-id: ee0ca2ac34ead6eea9316d27bcfbb1bc5a5955fd
17 files changed: