| commit | 3fcc34ef5aa873a67e32f0e6ea3d0a63543762bf | |
| author | Jordan DeLong <jdelong@fb.com> | |
| Tue, 24 Jun 2014 00:07:06 +0000 (23 17:07 -0700) | ||
| committer | facebook-github-bot <githubbot@fb.com> | |
| Mon, 30 Jun 2014 03:30:24 +0000 (29 20:30 -0700) | ||
| tree | e9904e1ca56d2b905f9d0135f804fc7341de1275 | treesnapshot (tar.gz zip) |
| parent | 3580f11f43199fab71aee22fdbe2a21c41330e67 | commitdiff |
Refactor running psp hooks so it's not part of hphp_context_exit
Summary: Rather than sending a bool into the function---I want to make it
easier to deal with PSP as a separate step so we can possibly change whether it
runs after a request ends with a fatal. The final defaulted arg was also only
for the PSP code, and the shutdown arg was always passed true. I am changing
the RPCRequestHandler not to call the post-psp debugger hook because I think it
was probably actually not intentionally doing so (since it doesn't run psp).
Also removed the ExecutionContext* argument: hphp_session_exit seems to be
willing to assume we're doing it to g_context, and I think we can afford the
extra load from TLS.
Reviewed By: @jano
Differential Revision: D1405002
Summary: Rather than sending a bool into the function---I want to make it
easier to deal with PSP as a separate step so we can possibly change whether it
runs after a request ends with a fatal. The final defaulted arg was also only
for the PSP code, and the shutdown arg was always passed true. I am changing
the RPCRequestHandler not to call the post-psp debugger hook because I think it
was probably actually not intentionally doing so (since it doesn't run psp).
Also removed the ExecutionContext* argument: hphp_session_exit seems to be
willing to assume we're doing it to g_context, and I think we can afford the
extra load from TLS.
Reviewed By: @jano
Differential Revision: D1405002