| commit | 3ef8fd99af5f09652afbfa240e84558b3d9286c8 | |
| author | Jake Bailey (Hacklang) <jakebailey@fb.com> | |
| Tue, 25 Feb 2020 01:04:17 +0000 (24 17:04 -0800) | ||
| committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | |
| Tue, 25 Feb 2020 01:07:09 +0000 (24 17:07 -0800) | ||
| tree | 2e489fd318d6600c5aae727a55196a2033c59477 | treesnapshot (tar.gz zip) |
| parent | a981852fd7d4f260ca27b3513894b89d9d19f9ec | commitdiff |
Local-memory fixme provider for Local_memory and Decl_service backends
Summary: Store the HH_FIXMEs we collected during parsing in the Provider_backend.t, when using the Local_memory and Decl_service backends. I think this should work fine for sIDE. It may cause issues for the Decl_service if we still have cases where decl-FIXMEs in another file can suppress errors in the file being typechecked (and in that case, we'd need to send back FIXMEs from the decl service), but hopefully we'll eliminate those cases soon.
Reviewed By: arxanas
Differential Revision: D19819526
fbshipit-source-id: 5b4d823a732666874944bb084a829e773f1cde21
Summary: Store the HH_FIXMEs we collected during parsing in the Provider_backend.t, when using the Local_memory and Decl_service backends. I think this should work fine for sIDE. It may cause issues for the Decl_service if we still have cases where decl-FIXMEs in another file can suppress errors in the file being typechecked (and in that case, we'd need to send back FIXMEs from the decl service), but hopefully we'll eliminate those cases soon.
Reviewed By: arxanas
Differential Revision: D19819526
fbshipit-source-id: 5b4d823a732666874944bb084a829e773f1cde21