Remove genDecRef from TraceBuilder
commit3e93f5404ee11b6960569e585fa0bcf8456354fa
authorJordan DeLong <jdelong@fb.com>
Thu, 25 Apr 2013 04:15:01 +0000 (24 21:15 -0700)
committerSara Golemon <sgolemon@fb.com>
Thu, 2 May 2013 04:00:39 +0000 (1 21:00 -0700)
treeb14778b59c1e69a89a0d0c301d25678421af56d5
parenta2eec97e6223f5e31d4bb02bcd8cbf71abc19876
Remove genDecRef from TraceBuilder

Replace with a preOptimizeDecRef.  Also caught a pseudo-issue
where we relied on the isRefCounted short-circuit for correctness (we
called genDecRef on Type::Cls).  That short-circuit is duplicated in
simplifier, and is stateless, so let's leave it there.  Remove some
dead code about BoxedCells and replace it with a comment in
ir.specification based on a conversation with @bsimmers.

(This is on top of all the other related diffs.)
hphp/doc/ir.specification
hphp/runtime/vm/translator/hopt/hhbctranslator.cpp
hphp/runtime/vm/translator/hopt/tracebuilder.cpp
hphp/runtime/vm/translator/hopt/tracebuilder.h
hphp/runtime/vm/translator/hopt/vectortranslator.cpp