| commit | 3deec61f2df5398b4fb8f9b5b46d2a46b6991655 | |
| author | Waleed Khan <waleedk@fb.com> | |
| Thu, 25 Jun 2020 21:24:33 +0000 (25 14:24 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Wed, 1 Jul 2020 01:12:32 +0000 (30 18:12 -0700) | ||
| tree | ea14a69acfbce39dbb00606d15ccaddf72f5ca94 | treesnapshot (tar.gz zip) |
| parent | 66dc3bb9bb5bfd1ac3d0243719cc0849f989f50e | commitdiff |
`calculate_errors` mode
Summary:
`hh_fanout calculate-errors` calculates the set of errors in the codebase.
Note that previously, we were doing something misleading: we were typechecking each changed file and adding their dependencies to the dependency graph. This can give correct results more often, but it's insufficient in general, since you need to perform a typecheck of the fanout files to get the real dependency graph delta.
Typechecking the changed files by themselves is still useful for the "prechecked files optimization" (an optimization where you color dependency edges based on whether the user directly changed the file that created them). However, we're not implementing that right now, and it adds some complexity, so this commit removes the old typecheck-changed-files system. We now only store dependency graph deltas whenever we perform a typecheck.
Reviewed By: ljw1004
Differential Revision: D21822109
fbshipit-source-id: a6303b1c2f9036b316af134f082364cece0ce0a8
Summary:
`hh_fanout calculate-errors` calculates the set of errors in the codebase.
Note that previously, we were doing something misleading: we were typechecking each changed file and adding their dependencies to the dependency graph. This can give correct results more often, but it's insufficient in general, since you need to perform a typecheck of the fanout files to get the real dependency graph delta.
Typechecking the changed files by themselves is still useful for the "prechecked files optimization" (an optimization where you color dependency edges based on whether the user directly changed the file that created them). However, we're not implementing that right now, and it adds some complexity, so this commit removes the old typecheck-changed-files system. We now only store dependency graph deltas whenever we perform a typecheck.
Reviewed By: ljw1004
Differential Revision: D21822109
fbshipit-source-id: a6303b1c2f9036b316af134f082364cece0ce0a8