| commit | 3d4608b54c491d372731b3100de016f8328030c2 | |
| author | Wilfred Hughes <wilfred@fb.com> | |
| Fri, 22 Apr 2022 19:42:12 +0000 (22 12:42 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Fri, 22 Apr 2022 19:42:12 +0000 (22 12:42 -0700) | ||
| tree | fddda49f2805a161208b3d6c9f8824f33238f6cf | treesnapshot (tar.gz zip) |
| parent | a3a375de72bcbc0a58e8b542103d00d52d08a872 | commitdiff |
Only offer enum class completion results when cursor is in an enum class context
Summary:
Previously, we'd always offer enum class fields after `#`, regardless of the position of the cursor. This prevented us offering useful completion after enum class syntax.
Looks like we missed this condition in D35496366 (https://github.com/facebook/hhvm/commit/91a898af4712851f49f68b73dde2ed99a51c9054).
Reviewed By: hgoldstein
Differential Revision: D35796054
fbshipit-source-id: 1e75a9cf9dc886b593b250c26fa379cdf98c5e73
Summary:
Previously, we'd always offer enum class fields after `#`, regardless of the position of the cursor. This prevented us offering useful completion after enum class syntax.
Looks like we missed this condition in D35496366 (https://github.com/facebook/hhvm/commit/91a898af4712851f49f68b73dde2ed99a51c9054).
Reviewed By: hgoldstein
Differential Revision: D35796054
fbshipit-source-id: 1e75a9cf9dc886b593b250c26fa379cdf98c5e73
| hphp/hack/src/server/autocompleteService.ml | diffblobblamehistory | |
| hphp/hack/test/autocomplete/enum_class_label/after_enum_call_call.php | [new file with mode: 0644] | blob |
| hphp/hack/test/autocomplete/enum_class_label/after_enum_call_call.php.exp | [new file with mode: 0644] | blob |