| commit | 3c19304c970c60a9572b1d174d47f5b33012cfab | |
| author | Shaunak Kishore <kshaunak@fb.com> | |
| Fri, 19 Jul 2019 01:15:43 +0000 (18 18:15 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Fri, 19 Jul 2019 01:21:00 +0000 (18 18:21 -0700) | ||
| tree | defec9326099b66a9343f25a0e67574404471174 | treesnapshot (tar.gz zip) |
| parent | 917d8370bdc91a91b384e21cfce1c0e8c4f604d8 | commitdiff |
Handle AtomicLowPtr in rawptr
Summary:
The `rawptr` gdb helper didn't the AtomicLowPtr smart pointer correctly before this: casting std::atomic to a pointer doesn't have the expected behavior.
This bug causes us to fail to print PHP function names in `walkstk` / `walkfp`, because they're stored in an AtomicLowPtr.
Reviewed By: markw65
Differential Revision: D16368557
fbshipit-source-id: 2fb6a4bb69d684b32691b2d754f4950864fa4287
Summary:
The `rawptr` gdb helper didn't the AtomicLowPtr smart pointer correctly before this: casting std::atomic to a pointer doesn't have the expected behavior.
This bug causes us to fail to print PHP function names in `walkstk` / `walkfp`, because they're stored in an AtomicLowPtr.
Reviewed By: markw65
Differential Revision: D16368557
fbshipit-source-id: 2fb6a4bb69d684b32691b2d754f4950864fa4287
| hphp/tools/gdb/gdbutils.py | diffblobblamehistory |