| commit | 3b8e7a67dd1d5704f1bc52d93d79d30f896bef6a | |
| author | Max Wang <mwang@fb.com> | |
| Mon, 28 Sep 2015 17:09:08 +0000 (28 10:09 -0700) | ||
| committer | hhvm-bot <hhvm-bot@fb.com> | |
| Mon, 28 Sep 2015 17:30:32 +0000 (28 10:30 -0700) | ||
| tree | 1889d4dff9d9c5eb23ebafc9be8b56e5d2eb5367 | treesnapshot (tar.gz zip) |
| parent | 2e48bc196c6e2fc9b072a688baa84b4601075ed3 | commitdiff |
Fix walkstk
Summary: - Change `sp' to `fp' because that's what it is.
- Use a better method for determining what code is part of the TC.
(Notably, the previous "primary" method, looking inside `mcg',
never actually worked.)
- Mark inlined frames better; previously, the most-inlined frame was
considered the "true frame", and the inlined-into frame was marked
{inlined frame}; now the reverse is true, which is more intuitive.
Reviewed By: @markw65
Differential Revision: D2483436
Summary: - Change `sp' to `fp' because that's what it is.
- Use a better method for determining what code is part of the TC.
(Notably, the previous "primary" method, looking inside `mcg',
never actually worked.)
- Mark inlined frames better; previously, the most-inlined frame was
considered the "true frame", and the inlined-into frame was marked
{inlined frame}; now the reverse is true, which is more intuitive.
Reviewed By: @markw65
Differential Revision: D2483436
| hphp/tools/gdb/frame.py | diffblobblamehistory | |
| hphp/tools/gdb/stack.py | diffblobblamehistory |